Skip to content

Complete typing for logger_utils.py #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

Complete typing for logger_utils.py #4134

merged 4 commits into from
May 23, 2025

Conversation

fmuenkel
Copy link
Contributor

Motivation and Explanation: Why and how do your changes improve the library?

More work on #3375

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

VascoSch92
VascoSch92 reviewed Jan 26, 2025
View reviewed changes
@JasonGrace2282 JasonGrace2282 added the typehints For adding/discussing typehints label Feb 9, 2025
@JasonGrace2282
Copy link
Member

Hi! Could you please set ignore_errors = False in mypy.ini, so that we can have mypy check this code in CI?
Thanks :)

@henrikmidtiby
Copy link
Contributor

I have continued work on this pull request, the updated pull request is available here: #4230

chopan050
chopan050 requested changes May 22, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The changes seem fine. There's only one thing which must be changed in mypy.ini and we would be done.

@chopan050 chopan050 enabled auto-merge (squash) May 23, 2025 01:07
chopan050
chopan050 approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chopan050 chopan050 merged commit fdc496c into ManimCommunity:main May 23, 2025
20 of 21 checks passed
@fmuenkel fmuenkel deleted the typing-logger-utils branch May 23, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VascoSch92 VascoSch92 VascoSch92 left review comments

@chopan050 chopan050 chopan050 approved these changes

Assignees
No one assigned
Labels
typehints For adding/discussing typehints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fmuenkel @JasonGrace2282 @henrikmidtiby @chopan050 @VascoSch92